-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option to fetch clinvar somatic classification + patch db for 115 #1794
Open
dglemos
wants to merge
5
commits into
main
Choose a base branch
from
add/clinvar_somatic_classification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dglemos
force-pushed
the
add/clinvar_somatic_classification
branch
from
November 20, 2024 09:26
126cae7
to
cf04640
Compare
dglemos
changed the title
Add new option to fetch clinvar somatic classification
Add new option to fetch clinvar somatic classification + patch db for 115
Nov 21, 2024
dglemos
force-pushed
the
add/clinvar_somatic_classification
branch
from
November 21, 2024 11:53
cf04640
to
780862b
Compare
Tests fail because of missing method |
nakib103
requested changes
Jan 13, 2025
@@ -239,6 +239,7 @@ CREATE TABLE `phenotype_feature` ( | |||
`seq_region_start` int(11) unsigned DEFAULT NULL, | |||
`seq_region_end` int(11) unsigned DEFAULT NULL, | |||
`seq_region_strand` tinyint(4) DEFAULT NULL, | |||
`DNA_type` enum('Germline','Somatic') DEFAULT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to add the dna_type_idx
as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSVAR-5941
Add option to return new clinvar somatic classification.
To test this code, please point to ensembl-variation update: Ensembl/ensembl-variation#1117